Convert discovery-* from integTest to [yaml | java]RestTest or internalClusterTest#60084
Conversation
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
mark-vieira
left a comment
mark-vieira
left a comment
There was a problem hiding this comment.
Couple minor comments, otherwise LGTM.
This also is another reminder that we need to get rid of these gross ant fixtures.
| } | ||
|
|
||
| //no unit tests | ||
| test.enabled = false |
There was a problem hiding this comment.
This seems like one step forward and one step back. I assume this is also just to appease our testing conventions stuff? If so I feel like this should not be a failure.
There was a problem hiding this comment.
yup. However, it is a bit more rare to have no unit tests (at least until i start converting the qa projects). For this one we will probably want to toggle the enable/disable the test task if the directory exists or not. I can look into that for a follow up PR.
There was a problem hiding this comment.
Yeah, we are going to have this all over the place for the qa projects that contain only rest tests.
| AntFixture fixture = tasks.create(name: "ec2Fixture${action}", type: AntFixture) { | ||
| dependsOn compileTestJava | ||
| env 'CLASSPATH', "${-> project.sourceSets.test.runtimeClasspath.asPath}" | ||
| dependsOn compileYamlRestTestJava |
There was a problem hiding this comment.
This should really be dependsOn project.sourceSets.yamlRestTest.runtimeClasspath. Just compileYamlRestTestJava doesn't include a) processing resources or b) upstream runtime dependencies so we risk a race condition here.
| task gceFixture(type: AntFixture) { | ||
| dependsOn compileTestJava | ||
| env 'CLASSPATH', "${-> project.sourceSets.test.runtimeClasspath.asPath}" | ||
| dependsOn compileYamlRestTestJava |
There was a problem hiding this comment.
Same as above, we should depending on the source set runtime classpath here, not just the compile task.
|
@elasticmachine update branch |
|
@elasticmachine update branch |
…alClusterTest (elastic#60084) For OSS plugins that begin with discovery-*, the integTest task is now a no-op and all of the tests are now executed via a test, yamlRestTest, javaRestTest, or internalClusterTest. related: elastic#56841 related: elastic#59444
mark-vieira
added
Team:Delivery
3 participants
For OSS plugins that begin with
discovery-*, theintegTesttask is now a no-op and all of the tests are now executed via a test,
yamlRestTest,javaRestTest, orinternalClusterTest.related: #56841
related: #59444